Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request Accessible Format form generation over-complex #1384

Open
KludgeKML opened this issue Mar 9, 2022 · 0 comments
Open

Request Accessible Format form generation over-complex #1384

KludgeKML opened this issue Mar 9, 2022 · 0 comments
Assignees

Comments

@KludgeKML
Copy link
Contributor

There's code in the helper for request accessible format that makes the html for for radio button with concealed option from an array in the localisation file. This is hard to test individually (because it contains optional rendering calls in a helper), and is just probably not very idiomatic for rails (this should be nested partials really).

https://github.com/alphagov/feedback/pull/1363/files#diff-6a9293f5dfa8d14e139688969ab5bb3fe70321dddcd67151af4b1352c9422d9aR16-R48

Tech-debt issuse to reduce this to simpler nested partials after release.

@KludgeKML KludgeKML self-assigned this Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant