Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Derive Deref for Sealed<T> #759

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Derive Deref for Sealed<T> #759

merged 1 commit into from
Oct 4, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Oct 4, 2024

Motivation

Reduce LOC for boilerplate code

Solution

Removes manual Deref impl in favour of derive_more::Deref

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@emhane emhane added the debt Refactor of code section that is hard to understand or maintain label Oct 4, 2024
mattsse
mattsse approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont mind this

@mattsse mattsse merged commit 038c464 into main Oct 4, 2024
28 of 29 checks passed
@mattsse mattsse deleted the emhane/derive-deref-sealed branch October 4, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@prestwich prestwich Awaiting requested review from prestwich

Assignees
No one assigned
Labels
debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emhane @mattsse