Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in func. shuffle in docqa/dataset.py #56

Open
YeDeming opened this issue Dec 10, 2018 · 0 comments
Open

Bug in func. shuffle in docqa/dataset.py #56

YeDeming opened this issue Dec 10, 2018 · 0 comments

Comments

@YeDeming
Copy link

Hi, Clark

Thanks for your opening source code!

I found a bug in shuffle function:

def shuffle_list_buckets(data, key, rng):
    start = 0
    end = 0
    while start < len(data):
        while end < len(data) and key(data[start]) == key(data[end]):
            end += 1
        rng.shuffle(data[start:end])
        start = end
    return data

rng.shuffle(data[start:end]) doesn't shuffle the the slice of data

Deming Ye

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant