Tag dependency #355
Open
Tag dependency #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ferdudas97
requested changes
Dec 16, 2022
...control-core/src/main/kotlin/pl/allegro/tech/servicemesh/envoycontrol/groups/NodeMetadata.kt
Show resolved
Hide resolved
...control-core/src/main/kotlin/pl/allegro/tech/servicemesh/envoycontrol/groups/NodeMetadata.kt
Show resolved
Hide resolved
...legro/tech/servicemesh/envoycontrol/snapshot/resource/listeners/EnvoyListenersFactoryTest.kt
Outdated
Show resolved
Hide resolved
.../allegro/tech/servicemesh/envoycontrol/snapshot/resource/clusters/EnvoyClusterFactoryTest.kt
Show resolved
Hide resolved
...rc/test/kotlin/pl/allegro/tech/servicemesh/envoycontrol/snapshot/EnvoySnapshotFactoryTest.kt
Outdated
Show resolved
Hide resolved
...rc/test/kotlin/pl/allegro/tech/servicemesh/envoycontrol/snapshot/EnvoySnapshotFactoryTest.kt
Outdated
Show resolved
Hide resolved
.../pl/allegro/tech/servicemesh/envoycontrol/snapshot/resource/clusters/EnvoyClustersFactory.kt
Outdated
Show resolved
Hide resolved
...rol-core/src/main/kotlin/pl/allegro/tech/servicemesh/envoycontrol/snapshot/GlobalSnapshot.kt
Outdated
Show resolved
Hide resolved
...re/src/main/kotlin/pl/allegro/tech/servicemesh/envoycontrol/snapshot/EnvoySnapshotFactory.kt
Outdated
Show resolved
Hide resolved
...re/src/main/kotlin/pl/allegro/tech/servicemesh/envoycontrol/snapshot/EnvoySnapshotFactory.kt
Outdated
Show resolved
Hide resolved
Ferdudas97
reviewed
Dec 21, 2022
...rol-core/src/main/kotlin/pl/allegro/tech/servicemesh/envoycontrol/snapshot/GlobalSnapshot.kt
Outdated
Show resolved
Hide resolved
.../pl/allegro/tech/servicemesh/envoycontrol/snapshot/resource/clusters/EnvoyClustersFactory.kt
Outdated
Show resolved
Hide resolved
...re/src/main/kotlin/pl/allegro/tech/servicemesh/envoycontrol/snapshot/EnvoySnapshotFactory.kt
Outdated
Show resolved
Hide resolved
Ferdudas97
reviewed
Dec 28, 2022
.../pl/allegro/tech/servicemesh/envoycontrol/snapshot/resource/clusters/EnvoyClustersFactory.kt
Outdated
Show resolved
Hide resolved
Ferdudas97
previously approved these changes
Jan 2, 2023
matb4r
reviewed
Jan 2, 2023
...re/src/main/kotlin/pl/allegro/tech/servicemesh/envoycontrol/snapshot/EnvoySnapshotFactory.kt
Outdated
Show resolved
Hide resolved
...l/allegro/tech/servicemesh/envoycontrol/snapshot/resource/listeners/EnvoyListenersFactory.kt
Outdated
Show resolved
Hide resolved
.../allegro/tech/servicemesh/envoycontrol/snapshot/resource/clusters/EnvoyClusterFactoryTest.kt
Show resolved
Hide resolved
.../allegro/tech/servicemesh/envoycontrol/snapshot/resource/clusters/EnvoyClusterFactoryTest.kt
Outdated
Show resolved
Hide resolved
matb4r
previously approved these changes
Jan 4, 2023
Ferdudas97
previously approved these changes
Jan 19, 2023
matb4r
previously approved these changes
Jan 19, 2023
Ferdudas97
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduce new mechanism for specify dependencies. It allow to dynamically defines dependencies based on tags.