Replace portBindings.add with standard way of exposing ports

[slonka]

How to expose ports:
https://www.testcontainers.org/features/networking/#exposing-container-ports-to-the-host

Where to fix:

envoy-control/envoy-control-tests/src/main/kotlin/pl/allegro/tech/servicemesh/envoycontrol/config/consul/ConsulContainer.kt

Line 30 in b74ba3c

portBindings.add("$externalPort:$internalPort")

[Kornelos]

I'd like to take this one

[pzmi]

I've assigned you. Have fun :)

[Kornelos]

Unfortunately container.getMappedPort() works only after starting containers. Test classes logic relies on fetching the port number before starting container, so in my opinion current implementation is justified.

[pzmi]

I think @slonka had in mind using .withExposedPorts(8080, 8081) instead of portBindings.add("$externalPort:$internalPort")

[michal494]

I'll work on this during Hacktoberfest.