Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject SSL handshake for unknown SNI for panel and subscription ports #1328

Open
pulsarice opened this issue Jun 24, 2024 · 2 comments
Open
Labels
enhancement New feature or request low priority It should be done in proper time to deploy To be deployed during the time

Comments

@pulsarice
Copy link

Is your feature request related to a problem? Please describe.
When the panel is set to listen on a specific Domain, if we use this command curl https://panelIP:panelPort -Ivk we will see the certificate CN that was used on the panel.
An attacker could use the certificate CN as SNI to try to connect to server.

Describe the solution you'd like
Like xray-core's rejectUnknownSni feature, I think It would be better:
When the panel is set to listen on a specific Domain, if the SNI does not match the domain specified, the server would reject TLS handshakes altogether and would not announce the certificate CN specified on server.
something like nginx's ssl_reject_handshake directive.

@pulsarice pulsarice added the enhancement New feature or request label Jun 24, 2024
@pulsarice pulsarice changed the title Reject unknown SNI for panel and subscription ports Reject SSL handshake for unknown SNI for panel and subscription ports Jun 25, 2024
@alireza0 alireza0 added the to deploy To be deployed during the time label Jun 29, 2024
@alireza0
Copy link
Owner

Good idea in case of security.

@alireza0
Copy link
Owner

It avoid access to the panel if admin want to use self signed certificate or same.
It is better to make it optional which takes more time.
I am going to work on it in proper time

@alireza0 alireza0 added the low priority It should be done in proper time label Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority It should be done in proper time to deploy To be deployed during the time
Projects
None yet
Development

No branches or pull requests

2 participants