Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error text could be more descriptive in KeframeSelector #1578

Open
amoliski opened this issue Oct 12, 2023 · 0 comments
Open

Error text could be more descriptive in KeframeSelector #1578

amoliski opened this issue Oct 12, 2023 · 0 comments
Assignees

Comments

@amoliski
Copy link

I forgot to set the output format for the keyframe selection node in Meshroom- after processing the images, I got an error:
The keyframes selected from the input video have not been written on disk. The keyframes' SfMData file cannot be written.

I had to search through the source to find the reason the file could not be written at line ~690 in /src/aliceVision/keyframe/KeyframeSelector.cpp

// If the current media is a video and there is no output keyframe, the corresponding SfMData file will not be written
if (feed.isVideo() && outputExtension == "none") {
ALICEVISION_THROW(std::invalid_argument, "The keyframes ...")

It would be really nice if the error included the missing filetype as the reason, and it would be even nicer if extension was checked before the keyframe selection started so the processing isn't wasted.

@cbentejac cbentejac self-assigned this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants