fix: Improve code and simplify logic #2651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
liujuping
reviewed
Nov 15, 2023
| } | ||
|
|
||
| return [children]; |
There was a problem hiding this comment.
children 为 undefined 的情况和原来输出是否一样。重构建议先补充相关的单元测试用例。
There was a problem hiding this comment.
想问一下补充相关的单元测试用例，可以在node.test.ts文件中添加测试用例，来测试函数在重构前后输出结果是否一样吗？
liujuping
reviewed
Nov 20, 2023
| @@ -53,8 +54,63 @@ describe('Node 方法测试', () => { | |||
| designer = null; | |||
| project = null; | |||
| }); | |||
| //测试 children 为 undefined 时重构前后输出结果 | |||
| it('initialChildren and initialChildren2 should return the same result when children is undefined', () => { | |||
| //重构前的 Node 的 initialChildren 方法 | |||
There was a problem hiding this comment.
你的测试不应该自己模拟函数，应该用类似于下面的方式写。
// 导入Node类
const { Node } = require('./Node'); // 假设Node类位于Node.js文件中
// 创建一个测试套件
describe('Node Class', () => {
// 创建一个测试用例
it('should initialize children array with empty array when children is null', () => {
// 创建一个Node实例
const node = new Node();
// 调用initialChildren方法并传入null作为参数
const result = node.initialChildren(null);
// 预期结果是一个空数组
expect(result).to.deep.equal([]);
});
// 创建更多的测试用例来测试其他情况...
});There was a problem hiding this comment.
OK 问一下怎么比较改进前的方法🤔️
There was a problem hiding this comment.
不需要比较改进前的方法，主要看改进后的输入输出。
There was a problem hiding this comment.
可以的，可以再加一下 0 和 false 的测试用例。
liujuping
reviewed
Nov 22, 2023
| }); | ||
|
|
||
| // Case 5: When children is 0 | ||
| test('initialChildren returns result of initialChildren function when children is null ', () => { |
There was a problem hiding this comment.
// Case 5: When children is 0，
这里和 Case 4 是一样的。Case 6 也是
There was a problem hiding this comment.
Case 4、Case 5、 Case 6 不应该是一样的代码。
JackLian
pushed a commit
that referenced
this pull request
Nov 23, 2023
* fix: Improve code and simplify logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
改进代码逻辑