Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert "fix(material): fix rendering is blocked, when the url in the asset fails to load" #2434

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

liujuping
Copy link
Collaborator

Reverts #2388

当资产包 URL 加载出现问题时,资产包有缺失,正常渲染的情况下,会造成这部分组件的 schema 异常,例如 componentMap 异常,不应该做 catch 处理。

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Coverage report for packages/utils

St.
Category Percentage Covered / Total
🔴 Statements 48.8% 122/250
🔴 Branches 43.49% 117/269
🔴 Functions 41.77% 33/79
🔴 Lines 49.79% 117/235

Test suite run success

33 tests passing in 6 suites.

Report generated by 🧪jest coverage report action from ffda251

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Coverage report for packages/react-simulator-renderer

St.
Category Percentage Covered / Total
🔴 Statements 33.63% 114/339
🔴 Branches 14.88% 25/168
🔴 Functions 26.14% 23/88
🔴 Lines 34.23% 114/333

Test suite run success

2 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from ffda251

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Coverage report for packages/renderer-core

St.
Category Percentage Covered / Total
🟡 Statements 71.95% 908/1262
🟡 Branches 61.19% 566/925
🟡 Functions 68.88% 197/286
🟡 Lines 71.94% 892/1240

Test suite run success

96 tests passing in 8 suites.

Report generated by 🧪jest coverage report action from ffda251

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Coverage report for packages/designer

St.
Category Percentage Covered / Total
🟢 Statements 96.32% 2854/2963
🟢 Branches 88.77% 1628/1834
🟢 Functions 95.99% 862/898
🟢 Lines 96.39% 2779/2883

Test suite run success

370 tests passing in 42 suites.

Report generated by 🧪jest coverage report action from ffda251

@JackLian JackLian merged commit 2c2241e into develop Sep 4, 2023
19 checks passed
@JackLian JackLian deleted the revert-2388-fix/load-url-error-case branch September 4, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants