Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: keep this in parse expression function #2271

Merged
merged 3 commits into from
Apr 26, 2024
Merged

fix: keep this in parse expression function #2271

merged 3 commits into from
Apr 26, 2024

Conversation

rainke
Copy link
Contributor

@rainke rainke commented Jul 12, 2023

  1. Wrong work when function has __self
  2. All this will replaced anyway

@rainke
fix: keep this in parse expression function
c805bba 
1. Wrong work when function has `__self`
2. All `this` will replaced anyway
@JackLian JackLian removed their request for review July 13, 2023 01:21
@liujuping
Copy link
Collaborator

这个影响可能比较大，暂时先不合并，我先看看有没有受到影响的 case。

@rainke
fix: remove function bind
fc947d2 
If the returned function is bound to a context, there is no way to call it with `call` and `apply`.
@1ncounter 1ncounter merged commit 5d220ce into alibaba:develop Apr 26, 2024
10 of 11 checks passed
@1ncounter 1ncounter mentioned this pull request May 16, 2024
Merged
@1ncounter
Copy link
Collaborator

test case 没有通过 @rainke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liujuping liujuping Awaiting requested review from liujuping liujuping is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rainke @liujuping @1ncounter @JackLian