Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

material.setAssets typescript 类型定义错误 #2841

Closed
shiye515 opened this issue Jan 12, 2024 · 1 comment
Closed

material.setAssets typescript 类型定义错误 #2841

shiye515 opened this issue Jan 12, 2024 · 1 comment
Assignees
@liujuping
Labels
help wanted Extra attention is needed / 老铁，赚 PR 的机会来了
Milestone
1.3.0

Comments

@shiye515
Copy link

shiye515 commented Jan 12, 2024 •
edited
Loading

Describe the bug (required) / 详细描述 bug（必填）

A clear and concise description of what the bug is. / 请提供清晰且精确的 bug 描述

文件 packages/types/src/shell/api/material.ts中类型定义错误
原定义：

 /**
   * 设置「资产包」结构
   * set data for Assets
   * @returns void
   */
  setAssets(assets: IPublicTypeAssetsJson): void;

函数返回值应改为 Promise

Environments (please complete the following information) (required): / 请提供如下信息（必填）

  • @alilc/lowcode-types 1.3.0-beta.9, 1.2.5 都存在此问题
@liujuping liujuping added the help wanted Extra attention is needed / 老铁，赚 PR 的机会来了 label Jan 12, 2024
@github-actions GitHub Actions
Copy link

Hello @shiye515. We totally like your proposal/feedback, PR wanted。

你好 @shiye515，我们完全同意你的提议/反馈，欢迎 PR。

@liujuping liujuping mentioned this issue Jan 15, 2024
Merged
@liujuping liujuping self-assigned this Jan 15, 2024
@liujuping liujuping added this to the 1.3.0 milestone Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liujuping liujuping

Labels
help wanted Extra attention is needed / 老铁，赚 PR 的机会来了
Projects
None yet
Milestone
1.3.0
Development

No branches or pull requests
2 participants
@shiye515 @liujuping