add metric for queue #1756
Merged
add metric for queue #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Takuka0311
reviewed
Sep 13, 2024
messixukejia
approved these changes
Sep 13, 2024
Takuka0311
approved these changes
Sep 14, 2024
linrunqi08
approved these changes
Sep 14, 2024
yyuuttaaoo
reviewed
Sep 14, 2024
| @@ -58,14 +83,26 @@ bool SenderQueue::Remove(SenderQueueItem* item) { | |||
| ++mRead; | |||
| } | |||
| --mSize; | |||
|
|
|||
| mOutItemsCnt->Add(1); | |||
There was a problem hiding this comment.
这里为啥没有对称的mOutItemDataSizeBytes？
There was a problem hiding this comment.
因为没啥用，统计个数也只是为了计算平均延时，这个指标本身没有实际价值
yyuuttaaoo
reviewed
Sep 14, 2024
| @@ -220,6 +235,20 @@ void WriteMetrics::PrepareMetricsRecordRef(MetricsRecordRef& ref, | |||
| mHead = cur; | |||
| } | |||
|
|
|||
| void WriteMetrics::CreateMetricsRecordRef(MetricsRecordRef& ref, | |||
There was a problem hiding this comment.
这一对能在PrepareMetricsRecordRef中复用吗？让他们建立点联系，一看就知道API选用哪个
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
新增队列公共指标（除exactly once发送队列）
进入的数量、进入的size、出去的数量、总时延、队列长度、size
队列指标公共label
config_name、project、component_name、queue_type