feat: 1. support prom scrape_protocols, 2. support prom enable_compression #1719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catdogpandas
changed the title
messixukejia
requested changes
Aug 28, 2024
messixukejia
approved these changes
Aug 29, 2024
linrunqi08
reviewed
Aug 30, 2024
| val += ";q=0." + std::to_string(weight--); | ||
| tmpScrapeProtocol = val; | ||
| } | ||
| tmpScrapeProtocols.push_back("*/*;q=0." + ToString(weight)); |
There was a problem hiding this comment.
这个拼出来的字符串的含义是什么？会影响什么？
There was a problem hiding this comment.
这里是对不同的协议按照先后顺序设置权重，靠前的权重会高。会放到的请求头的 Accept 中。
比如text/plain;version=0.0.4;q=0.4,application/vnd.google.protobuf;proto=io.prometheus.client.MetricFamily;encoding=delimited;q=0.3,application/openmetrics-text;version=0.0.1;q=0.2,*/*;q=0.1这个情况会希望Exporter返回 text/plain 的优先级高。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.