fix: Correct premature file read termination triggered by sender back pressure #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -50,7 +50,14 @@ class BlockedEventManager : public LogstoreFeedBackInterface { | |||
| BlockedEvent() : mLogstoreKey(0), mEvent(NULL), mInvalidTime(time(NULL)), mTimeout(1) {} | |||
| void Update(const LogstoreFeedBackKey& logstoreKey, Event* pEvent, int32_t curTime) { | |||
| if (mEvent != NULL) { | |||
| delete mEvent; | |||
| // There are only two situations where event coverage is possible | |||
yyuuttaaoo
changed the title
yyuuttaaoo
approved these changes
Nov 28, 2023
yyuuttaaoo
pushed a commit
that referenced
this pull request
Dec 7, 2023
… pressure (#1251) Resolved an issue where incomplete file reads were occurring as a result of reader flush timeout events overwriting blocked events. This fix ensures that blocked events maintain priority, allowing files to be read fully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复BlockedEvent在update的时候，非预期的事件覆盖行为
问题现象：
NAS场景Json采集，CP文件的方式替代历史文件采集的情况下，发现大量文件只采集了一小部分。