Compile time failure for chained comparison expressions #587
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tzaffi pointed out that the code
Int(1) != Int(2) == Int(3)
is valid Python, yet it produces an unexpected result.The Python docs explain that a chained comparison of the form
a op b op c
should result ina op b and b op c
. Yet for the above example, we actually getInt(2) == Int(3)
(and this may rely on undefined behavior).The core problem is that Python uses the native
and
operator to combine chained comparisons. Since this operator cannot be override, we can't produce correct code for chained comparisons in PyTeal.This PR contains a potential solution to the issue by forbidding chained comparisons. It makes
Expr.__bool__
raise an error, which means using the nativeand
operator on two PyTeal expressions is no longer possible.To get this out of draft status, the following are needed: