Emit errors only when listeners are present #2

alexpenev-s · 2016-11-23T13:18:18Z

No description provided.

dotchev · 2016-11-23T14:56:51Z

Will this fix issue SAP#64?

dotchev · 2016-11-23T15:05:36Z

lib/protocol/Connection.js

@@ -223,8 +223,10 @@ Connection.prototype._addListeners = function _addListeners(socket) {
    if (cb) {
      self._state.receive = null; // a callback should be called only once
      cb(err);
-    } else {
+    } else if (self.listenerCount('error')) {


listenerCount is present since v3.2.0, see https://nodejs.org/api/events.html#events_emitter_listenercount_eventname
package.json says "node": ">= 0.12"
we could do it like this
self.listenerCount && self.listenerCount('error') || self.listeners('error').length

alexpenev-s force-pushed the connfix branch from 95f39bc to 8105450 Compare November 23, 2016 13:19

dotchev reviewed Nov 23, 2016

View reviewed changes

Emit errors only when listeners are present

5d338d3

alexpenev-s force-pushed the connfix branch from 8105450 to 5d338d3 Compare November 23, 2016 15:34

On socket end don't emit an additional event

96bf401

alexpenev-s force-pushed the connfix branch from c6210f4 to 96bf401 Compare December 5, 2016 07:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Emit errors only when listeners are present #2

Emit errors only when listeners are present #2

alexpenev-s commented Nov 23, 2016

dotchev commented Nov 23, 2016

dotchev Nov 23, 2016

Emit errors only when listeners are present #2

Are you sure you want to change the base?

Emit errors only when listeners are present #2

Conversation

alexpenev-s commented Nov 23, 2016

dotchev commented Nov 23, 2016

dotchev Nov 23, 2016

Choose a reason for hiding this comment