-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate filter clashes with gettext filter #108
Comments
I'm not really sure how the i18n code in this library would clash with anything else. Could you give me some more details on this issue? Or maybe a demo on jsbin (or similar)? |
Thanks Alex for the swift reply, here is the plunkr: You will see directives work just fine, however the filters do not as your filter comes across this one. Angular does not provide namspacing in 1.x |
I see the effect isn't quite the same to our application, what I see is that the labels are attempted to be translated (on the select control), so as you'd expect the effect is random as probably a "random" filter is being picked up. |
If people are using the gettext translate filter then the one packed with this control clashes and only partially works. It would be better if gettext version is marked as dependency with the control (like lokijs) so that users of this control can use the full functionality of gettext whilst also using this control.
Also there is no need to write your own translate functionality when it already exists here:
[(https://github.com/rubenv/angular-gettext)]
Please consider removing this filter from future versions of this control. In the meantime we are having to remove it from this control's source code which isn't ideal.
Thank you.
The text was updated successfully, but these errors were encountered: