Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Consolidate streaming logic #50

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

WIP: Consolidate streaming logic #50

wants to merge 7 commits into from

Conversation

alexanderatallah
Copy link
Owner

Unsuccessful attempt.

Bad surprises:

  • a user passing in onStreamResult and numOutputs > 1 will get no stream results
  • some kind of bug happens when doing numOutputs > 1

@vercel
Copy link

vercel bot commented Apr 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
window-ai ✅ Ready (Inspect) Visit Preview Apr 29, 2023 5:46pm

@alexanderatallah alexanderatallah marked this pull request as draft April 29, 2023 17:46
@alexanderatallah alexanderatallah changed the title Consolidate streaming logic WIP: Consolidate streaming logic Apr 29, 2023
@alexanderatallah alexanderatallah mentioned this pull request Apr 30, 2023
Open
@alexanderatallah alexanderatallah linked an issue Apr 30, 2023 that may be closed by this pull request
Allow streaming multiple outputs #52
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
No open projects
window.ai Roadmap
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow streaming multiple outputs
1 participant
@alexanderatallah