Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Metadata API Request Error Handling #3812

Closed
richardjennings-occrp opened this issue Jul 16, 2024 · 1 comment · Fixed by #3948
Closed

BUG: Metadata API Request Error Handling #3812

richardjennings-occrp opened this issue Jul 16, 2024 · 1 comment · Fixed by #3948
Labels
bug Things that should work, but don’t Low issue that could require attention

Comments

@richardjennings-occrp
Copy link
Contributor

Describe the bug
The UI does not utilise a retry limit or backoff for retrying Metadata API requests when the API is not available.

To Reproduce
Steps to reproduce the behavior:

  1. Start the UI without an Aleph API available

Expected behaviour
The UI should retry a number of times delayed by some form of backoff.

If a maximum number of retries is reached there should be some button to try again (refresh).

Aleph version
Current

Screenshots
network-error-spinning

Additional context
@richardjennings-occrp richardjennings-occrp added bug Things that should work, but don’t triage These issues need to be reviewed by the Aleph team labels Jul 16, 2024
@dimitardanailov dimitardanailov mentioned this issue Jul 16, 2024
Open
@dimitardanailov
Copy link

Dear @richardjennings-occrp

I've created a new pull request: #3813
I'd like to request to review my patch / pull request.

@catileptic catileptic added Low issue that could require attention and removed triage These issues need to be reviewed by the Aleph team labels Jul 30, 2024
tillprochaska added a commit that referenced this issue Oct 22, 2024
@tillprochaska
Fix infinite request loop if metadata request fails
4e8ebcb 
Fixes #3812. Previously, the UI would retry the metadata request indefinitely and without a delay. Now, if the metadata request fails, an error message and a button to reload the page are displayed.

I haven’t implemented automatic retries with back-offs for now, as this adds complexity and I’m not sure it’s necessary.
@tillprochaska tillprochaska mentioned this issue Oct 22, 2024
Merged
tillprochaska added a commit that referenced this issue Oct 22, 2024
@tillprochaska
Fix infinite request loop if metadata request fails
5ef2720 
Fixes #3812. Previously, the UI would retry the metadata request indefinitely and without a delay. Now, if the metadata request fails, an error message and a button to reload the page are displayed.

I haven’t implemented automatic retries with back-offs for now, as this adds complexity and I’m not sure it’s necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Things that should work, but don’t Low issue that could require attention
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix infinite request loop if metadata request fails alephdata/aleph
3 participants
@dimitardanailov @catileptic @richardjennings-occrp