Fix: An ETH account could not be initialized from its mnemonic #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users could not easily import or migrate accounts using their mnemonic representation. Solution: Add a static method `from_mnemonic` on the `ETHAccount` class. Discussion: This is a first step and this behaviour can be extended to more chains in the future.
|
Please note that this categorization is based solely on the provided information and may not fully reflect the complexity of the PR. It would be beneficial if you could provide additional rules or context to fine-tune the categorization process. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users could not easily import or migrate accounts using their mnemonic representation.
Solution: Add a static method
from_mnemonicon theETHAccountclass.Discussion: This is a first step and this behaviour can be extended to more chains in the future.