* Custom Domain, raise exception at the end of checks #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I got this to work and fix my issue, but the tests fail. |
aliel
force-pushed
the
aliel-fix-domain-checks
branch
from
bc04ec8
to
5ba821c
Compare
aliel
force-pushed
the
aliel-fix-domain-checks
branch
from
5ba821c
to
8c6dbf4
Compare
MHHukiewitz
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Based on @hoh's comment and ChatGPTs explanation:
Old: The method returned an error immediately when a mismatch was found.
New: The method now evaluates all DNS rules and then checks if all values in status are False. If so, it raises an error. This implies that now the method completes checking all rules before deciding to raise an error.
Tests are passing, so LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.