Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extended JSON encoder for datetime objects in message encoding #82

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

MHHukiewitz
Copy link
Member

@github-actions github-actions bot added the BLACK This PR has critical implications and must be reviewed by a senior engineer. label Nov 25, 2023
Copy link

  • Addition of a new function extended_json_encoder which handles serialization for various datetime types. This is a significant change as it affects the way data is encoded and decoded in the application.
  • Modification of the _prepare_aleph_message function to use the new extended_json_encoder instead of the previous encoder pydantic_encoder. This could potentially introduce bugs if the new encoder does not handle all cases that the previous encoder handled.

Copy link
Collaborator

@1yam 1yam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MHHukiewitz MHHukiewitz merged commit b11349b into main Nov 27, 2023
11 checks passed
@MHHukiewitz MHHukiewitz deleted the mhh-od-serialize-datetime branch November 27, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLACK This PR has critical implications and must be reviewed by a senior engineer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants