Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add allow_amend, internet and aleph_api parameters to create_program #77

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Add allow_amend, internet and aleph_api parameters to create_program #77

merged 1 commit into from
Nov 17, 2023

Conversation

MHHukiewitz
Copy link
Member

Yeah, that's pretty much it.

@github-actions github-actions bot added the BLUE This PR is simple and straightforward. label Nov 13, 2023
@github-actions GitHub Actions
Copy link

The pull request is categorized as BLUE due to the following reasons:

  • The changes in the diff only involve adding optional parameters to existing functions. This change is unlikely to introduce bugs and can be easily reviewed by less experienced developers.
  • There are no significant architectural changes or new features being introduced.
  • The scope of the changes is limited to a single file, which makes it easy for reviewers to understand the impact of these changes.

@MHHukiewitz MHHukiewitz mentioned this pull request Nov 13, 2023
Closed
1yam
1yam approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@1yam 1yam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MHHukiewitz MHHukiewitz merged commit 25a48da into main Nov 17, 2023
12 checks passed
@MHHukiewitz MHHukiewitz deleted the mhh-add-program-params branch November 17, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1yam 1yam 1yam approved these changes

Assignees
No one assigned
Labels
BLUE This PR is simple and straightforward.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MHHukiewitz @1yam