Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AlephApp.vm_hash #52

Merged
merged 3 commits into from
Sep 5, 2023
Merged

Add AlephApp.vm_hash #52

merged 3 commits into from
Sep 5, 2023

Conversation

MHHukiewitz
Copy link
Member

This simple property returns the item_hash of the Aleph message that created the VM that is currently running (and invoking the method).

@MHHukiewitz MHHukiewitz requested a review from hoh August 24, 2023 13:25
hoh
hoh reviewed Aug 28, 2023
View reviewed changes
Copy link
Member

@hoh hoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good initiative. A few comments.

src/aleph/sdk/vm/app.py Outdated Show resolved Hide resolved
src/aleph/sdk/vm/app.py Outdated Show resolved Hide resolved
@MHHukiewitz MHHukiewitz assigned hoh and unassigned MHHukiewitz Aug 28, 2023
@MHHukiewitz MHHukiewitz requested a review from hoh August 28, 2023 20:33
@odesenfans odesenfans merged commit 5d66bf7 into main Sep 5, 2023
10 checks passed
@odesenfans odesenfans deleted the mhh-get-vm-hash branch September 5, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odesenfans odesenfans odesenfans approved these changes

@hoh hoh Awaiting requested review from hoh

Assignees

@hoh hoh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MHHukiewitz @hoh @odesenfans