Cosmos signature verification and fix #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regarding encoding bytes with base64: cosmos/cosmos-sdk#12910 (comment) Cosmos did, or will do, a transition from base64 to hex bytes, similar to Ethereum |
MHHukiewitz
force-pushed
the
mhh-cosmos-sig-verify-and-test
branch
from
3e17343
to
3e43533
Compare
Solution: Fix sign() function and add signature verification func + test + add requirements
MHHukiewitz
force-pushed
the
mhh-cosmos-sig-verify-and-test
branch
from
ecfacba
to
db819e9
Compare
hoh
force-pushed
the
mhh-cosmos-sig-verify-and-test
branch
from
db819e9
to
739b4a9
Compare
hoh
force-pushed
the
mhh-cosmos-sig-verify-and-test
branch
from
739b4a9
to
c6f2be4
Compare
MHHukiewitz
force-pushed
the
mhh-cosmos-sig-verify-and-test
branch
from
c6f2be4
to
1059c08
Compare
|
Closing for now, as it is not needed and maintaining our own branch of the cosmos-sdk might not seem worth it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cosmos code hasn't been updated since 2020. I added a test file for CSDK to check whether the signature verification function works correctly and found that the signing did not work at all.
I fixed it by making
CSDKAccount.public_key()directly return a base64-encoded string, which is what is being stored inside the signature dictionary.Added the
verifiy_signature()function as in Feature: Signature verification for Solana and Ethereum messages #19.Added
ecdsaandcosmospyto the testing requirements.