-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
small improvements extracted from #113 #136
Conversation
Co-authored-by: Laurent Peuch <[email protected]>
Co-authored-by: Laurent Peuch <[email protected]>
Co-authored-by: Laurent Peuch <[email protected]>
6031c7e
to
9c5ec6e
Compare
This PR introduces significant changes to the SDK library for the Aleph.im network. It involves changes to the 'pyproject.toml' file, which lists the dependencies of the project. It also modifies the 'src/aleph/sdk/chains/sol.py' file, which is a part of the Solana chain module, and the 'src/aleph/sdk/chains/solana.py' file, which is a new file for the Solana chain module. The changes in 'pyproject.toml' include the removal of 'typer' and the addition of 'substrate' as a dependency. This suggests that the project now uses Substrate for its blockchain interactions. The changes in 'src/aleph/sdk/chains/sol.py' and 'src/aleph/sdk/chains/solana.py' are significant because they replace the old Sol module with a new Solana module. The removal of 'typer' and the addition of 'substrate' indicate a potential shift in the project's architecture and could potentially introduce new risks. The addition of a new file for the Solana chain module also suggests that the project is planning to support a new blockchain, Solana, in the future. The PR also mentions that the 'aleph.sdk.chains.sol' module is deprecated. This could indicate that the old Sol module is being phased out in favor of the new Solana module. Therefore, this PR is likely to be a 'BLACK' PR because it involves significant changes to the project's architecture and uses of blockchain technologies, which could potentially introduce new risks and require deep understanding of the project's codebase. Please consider carefully before merging this PR, as it may require extensive testing and code review. --- aleph-im/aleph-sdk-python RED This PR introduces changes to the SDK library for the Aleph.im network. It involves changes to the 'pyproject.toml' file, which lists the dependencies of the project. It also modifies the 'src/aleph/sdk/chains/sol.py' file, which is a part of the Solana chain module. The changes in 'pyproject.toml' include the removal of 'typer' and the addition of 'substrate' as a dependency. This suggests that the project now uses Substrate for its blockchain interactions. The changes in 'src/aleph/sdk/chains/sol.py' are significant because they replace the old Sol module with a new Solana module. The removal of 'typer' and the addition of 'substrate' indicate a potential shift in the project's architecture and could potentially introduce new risks. The PR also mentions that the 'aleph.sdk.chains.sol' module is deprecated. This could indicate that the old Sol module is being phased out in favor of the new Solana module. Therefore, this PR is likely to be a 'RED' PR because it involves significant changes to the project's architecture and uses of blockchain technologies, which could potentially introduce new risks and require deep understanding of the project's codebase. However, the changes are not complex and do not involve major changes to the project's logic. Therefore, this PR should be reviewed carefully before merging, as it may require extensive testing and code review. |
Those 3 commits are extracted from #113 PR and are here to be easier to merge
and making #113 easier to reread.