Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small improvements extracted from #113 #136

Merged
merged 3 commits into from
Jun 28, 2024
Merged

small improvements extracted from #113 #136

merged 3 commits into from
Jun 28, 2024

Conversation

Psycojoker
Copy link
Collaborator

@Psycojoker Psycojoker commented Jun 27, 2024

Those 3 commits are extracted from #113 PR and are here to be easier to merge
and making #113 easier to reread.

  • feat: rename aleph.sdk.chains.sol to aleph.sdk.chains.solana
  • feat: rename polkadot extra to substrate
  • refactor: remove unused dependency typer

@Psycojoker Psycojoker requested a review from hoh June 27, 2024 17:03
@github-actions github-actions bot added the BLACK This PR has critical implications and must be reviewed by a senior engineer. label Jun 27, 2024
Copy link

This PR introduces significant changes to the SDK library for the Aleph.im network. It involves changes to the 'pyproject.toml' file, which lists the dependencies of the project. It also modifies the 'src/aleph/sdk/chains/sol.py' file, which is a part of the Solana chain module, and the 'src/aleph/sdk/chains/solana.py' file, which is a new file for the Solana chain module.

The changes in 'pyproject.toml' include the removal of 'typer' and the addition of 'substrate' as a dependency. This suggests that the project now uses Substrate for its blockchain interactions. The changes in 'src/aleph/sdk/chains/sol.py' and 'src/aleph/sdk/chains/solana.py' are significant because they replace the old Sol module with a new Solana module.

The removal of 'typer' and the addition of 'substrate' indicate a potential shift in the project's architecture and could potentially introduce new risks. The addition of a new file for the Solana chain module also suggests that the project is planning to support a new blockchain, Solana, in the future.

The PR also mentions that the 'aleph.sdk.chains.sol' module is deprecated. This could indicate that the old Sol module is being phased out in favor of the new Solana module.

Therefore, this PR is likely to be a 'BLACK' PR because it involves significant changes to the project's architecture and uses of blockchain technologies, which could potentially introduce new risks and require deep understanding of the project's codebase.

Please consider carefully before merging this PR, as it may require extensive testing and code review.

--- aleph-im/aleph-sdk-python

RED

This PR introduces changes to the SDK library for the Aleph.im network. It involves changes to the 'pyproject.toml' file, which lists the dependencies of the project. It also modifies the 'src/aleph/sdk/chains/sol.py' file, which is a part of the Solana chain module.

The changes in 'pyproject.toml' include the removal of 'typer' and the addition of 'substrate' as a dependency. This suggests that the project now uses Substrate for its blockchain interactions.

The changes in 'src/aleph/sdk/chains/sol.py' are significant because they replace the old Sol module with a new Solana module.

The removal of 'typer' and the addition of 'substrate' indicate a potential shift in the project's architecture and could potentially introduce new risks.

The PR also mentions that the 'aleph.sdk.chains.sol' module is deprecated. This could indicate that the old Sol module is being phased out in favor of the new Solana module.

Therefore, this PR is likely to be a 'RED' PR because it involves significant changes to the project's architecture and uses of blockchain technologies, which could potentially introduce new risks and require deep understanding of the project's codebase.

However, the changes are not complex and do not involve major changes to the project's logic. Therefore, this PR should be reviewed carefully before merging, as it may require extensive testing and code review.

@Psycojoker Psycojoker changed the title small improvements extracted from !113 small improvements extracted from #113 Jun 27, 2024
@hoh hoh merged commit 94fb089 into main Jun 28, 2024
15 checks passed
@Psycojoker Psycojoker deleted the small-improvments branch July 24, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLACK This PR has critical implications and must be reviewed by a senior engineer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants