Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type hints #121

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Fix type hints #121

merged 2 commits into from
Jun 13, 2024

Conversation

hoh
Copy link
Member

@hoh hoh commented Jun 7, 2024

  • Fix: Typing of item hashes were str not ItemHash
  • Fix: Typing: Protocol AccountFromPrivateKey lacked method sign_raw

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.17%. Comparing base (fd1b0e1) to head (68f1a47).
Report is 1 commits behind head on main.

Current head 68f1a47 differs from pull request most recent head bd6f43d

Please upload reports for the commit bd6f43d to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
+ Coverage   84.15%   84.17%   +0.01%     
==========================================
  Files          27       27              
  Lines        1130     1131       +1     
  Branches      188      188              
==========================================
+ Hits          951      952       +1     
  Misses        176      176              
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 8, 2024

Failed to retrieve llama text: POST 504:

504 Gateway Time-out


The server didn't respond in time.

@hoh hoh merged commit 214db7c into main Jun 13, 2024
17 checks passed
@Psycojoker Psycojoker deleted the hoh-fix-typing branch July 24, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants