Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Hashing for Caching Dependencies in Build Wheel GH Action #116

Merged
merged 5 commits into from
Apr 8, 2024

Conversation

MHHukiewitz
Copy link
Member

@MHHukiewitz MHHukiewitz commented Apr 7, 2024

Still tried to hash now-nonexistant setup.cfg and setup.py files to determine hash to lookup cached dependencies.

This causes the latest CI/CD flow on main to fail.

Copy link

github-actions bot commented Apr 7, 2024

The PR is modifying the GitHub Actions workflow file build-wheels.yml in the repository aleph-im/aleph-sdk-python. The changes involve updating the cache key for building wheels in Python. This change could potentially affect other parts of the codebase that rely on this specific caching mechanism, leading to potential bugs or issues if not handled correctly.

The new cache key is ${{ runner.os }}-build-wheels-${{ hashFiles('pyproject.toml') }} which means it will depend on the content of the pyproject.toml file for caching purposes. This could potentially lead to issues if the structure or contents of this file change, as it influences how dependencies are cached and built.

In conclusion, while 'BLACK' PRs can be challenging due to their potential impact on other parts of the codebase, they require careful consideration and review by experienced developers. The label should only be used when necessary.

@github-actions github-actions bot added the BLACK This PR has critical implications and must be reviewed by a senior engineer. label Apr 7, 2024
Copy link

codecov bot commented Apr 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.67%. Comparing base (2a0b789) to head (37284d4).

❗ Current head 37284d4 differs from pull request most recent head ca2bfda. Consider uploading reports for the commit ca2bfda to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #116   +/-   ##
=======================================
  Coverage   83.67%   83.67%           
=======================================
  Files          27       27           
  Lines        1084     1084           
  Branches      181      181           
=======================================
  Hits          907      907           
  Misses        175      175           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…quirement; Remove ethereum extra package, as it was already contained in main package
…breaking pydantic requirements in 0.11.1 and 0.12.1 that did not exist in 0.11.0 and 0.12.0 respectively
@MHHukiewitz
Copy link
Member Author

We should probably start upgrading to Pydantic 2 at some point

@MHHukiewitz MHHukiewitz requested a review from hoh April 8, 2024 10:56
@MHHukiewitz MHHukiewitz merged commit 1c2d57d into main Apr 8, 2024
10 checks passed
@MHHukiewitz MHHukiewitz deleted the mhh-fix-build-wheel-cache branch April 8, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLACK This PR has critical implications and must be reviewed by a senior engineer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants