Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Feature] Deprecation messages for invalid imports" #102

Closed
wants to merge 9 commits into from

Conversation

MHHukiewitz
Copy link
Member

Reverts #94

@github-actions github-actions bot added the BLUE This PR is simple and straightforward. label Feb 11, 2024
Copy link

The 'aleph-message==0.4.1' change in setup.cfg could be considered as BLUE, as it is unlikely to introduce bugs and doesn't involve any major refactoring or changes that would affect other parts of the codebase significantly.

However, there are a few RED indicators:

  • The removal of raise NotImplementedError in abstract methods from aleph/sdk/client/abstract.py could indicate some new features or modifications to existing logic that might require deeper review and understanding of the codebase.
  • Changes in 'eth_abi==4.0.0b2' in setup.cfg may affect other parts of the project, especially those using this library.

Finally, there are a few BLACK indicators:

  • The removal of raise NotImplementedError in abstract methods from aleph/sdk/client/abstract.py could indicate extensive changes that have a high potential for introducing bugs or require deep understanding of the project architecture.
  • Changes in 'eth_abi==4.0.0b2' in setup.cfg may affect other parts of the project, especially those using this library.

Please note that these are just initial assessments based on the provided diff and rules. A more thorough review would be needed to confirm these categorizations.

Here is your response:

## Categorization: BLUE, RED, BLACK
- **BLUE**: Small changes in setup.cfg (aleph-message==0.4.1), no new features or modifications to existing logic identified.
- **RED**: Potential for introducing bugs due to removal of `raise NotImplementedError` from abstract methods, and potential impact on other parts of the project due to changes in 'eth_abi'.
- **BLACK**: Extensive changes that have a high potential for introducing bugs or require deep understanding of the project architecture. Removal of `raise NotImplementedError` from abstract methods and change in 'eth_abi' are considered BLACK indicators. 

I hope this helps you understand the complexity level of your PR. Please let me know if there is anything else I can assist you with.

@MHHukiewitz MHHukiewitz deleted the revert-94-mhh-add-deprecation-message branch February 11, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLUE This PR is simple and straightforward.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant