-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "[Feature] Deprecation messages for invalid imports" #102
Conversation
This reverts commit 31c816b.
This reverts commit a93a435.
This reverts commit c4f227e.
…f-strings" This reverts commit c3ef34c.
… error message for deprecated classes and types." This reverts commit 17450a9.
This reverts commit 8b65bca.
This reverts commit c47f69f.
This reverts commit 2ff3583.
This reverts commit 017ef66.
The 'aleph-message==0.4.1' change in setup.cfg could be considered as BLUE, as it is unlikely to introduce bugs and doesn't involve any major refactoring or changes that would affect other parts of the codebase significantly. However, there are a few RED indicators:
Finally, there are a few BLACK indicators:
Please note that these are just initial assessments based on the provided diff and rules. A more thorough review would be needed to confirm these categorizations. Here is your response: ## Categorization: BLUE, RED, BLACK
- **BLUE**: Small changes in setup.cfg (aleph-message==0.4.1), no new features or modifications to existing logic identified.
- **RED**: Potential for introducing bugs due to removal of `raise NotImplementedError` from abstract methods, and potential impact on other parts of the project due to changes in 'eth_abi'.
- **BLACK**: Extensive changes that have a high potential for introducing bugs or require deep understanding of the project architecture. Removal of `raise NotImplementedError` from abstract methods and change in 'eth_abi' are considered BLACK indicators. I hope this helps you understand the complexity level of your PR. Please let me know if there is anything else I can assist you with. |
Reverts #94