Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Any type to defaults #512

Merged
merged 3 commits into from
Jun 16, 2024
Merged

Add Any type to defaults #512

merged 3 commits into from
Jun 16, 2024

Conversation

elupus
Copy link
Contributor

@elupus elupus commented Jun 6, 2024

These function ended up as only accepting UNDEFINED as argument since the function was partially typed.

These function ended up as only accepting UNDEFINED as argument since the function was partially typed.
@elupus elupus changed the title Add Any type to defu Add Any type to defaults Jun 6, 2024
Copy link

@farmio farmio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same for Required

@elupus
Copy link
Contributor Author

elupus commented Jun 6, 2024

Fixed

Copy link
Owner

@alecthomas alecthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks.

@spacegaier spacegaier merged commit 9451b61 into alecthomas:master Jun 16, 2024
9 checks passed
@elupus elupus deleted the patch-1 branch June 16, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants