New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop duplicated type checks in Schema._compile #495

Merged

alecthomas merged 1 commit into alecthomas:master from emontnemery:patch-1

Dec 1, 2023

Contributor

emontnemery commented Dec 1, 2023

Schema._compile calls isinstance to check for list and Mapping, hence the check further down testing for list or dict can never be True.


          Drop duplicated type checks in Schema._compile

95153d3

alecthomas approved these changes

View reviewed changes

alecthomas merged commit 891b2ea into alecthomas:master

6 checks passed

Owner

alecthomas commented Dec 1, 2023

Nice catch, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet