Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest substituting $password rather than obscuring #6

Open
jangari opened this issue Sep 16, 2017 · 1 comment
Open

Suggest substituting $password rather than obscuring #6

jangari opened this issue Sep 16, 2017 · 1 comment

Comments

@jangari
Copy link

jangari commented Sep 16, 2017

kpcli/kpcli.pl

Line 1852 in cbcd27c

$password = colored(['red on_red'], $password);

I see the point of obscuring the password with red on red, but this could be a security flaw if a user ran show and then quit, as the password would still be in their terminal buffer and could be copied. I've modified my copy so that each character is replaced by an asterisk when running show. Running show -f still shows plan text passwords.

PS, great program. I have basically replaced KeePassX with this.

@pepa65
Copy link

pepa65 commented Jul 23, 2019

The colour-on-colour is handy for copying the password, but perhaps the screen terminal buffer should always be cleared on exit? (Is this possible??)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants