Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

library improvement: ANTLR2 to ANTLR4 #30

Open
2 of 4 tasks
duttonw opened this issue Oct 28, 2019 · 1 comment
Open
2 of 4 tasks

library improvement: ANTLR2 to ANTLR4 #30

duttonw opened this issue Oct 28, 2019 · 1 comment
Assignees

Comments

@duttonw
Copy link

duttonw commented Oct 28, 2019

This is in relation to getting seam java 11 happy

  • remove org.codehaus.mojo:antlr-maven-plugin:2.2
  • Update antlr:antlr:2.7.6 to org.antlr:antlr4:4.7.2
  • Upgrade source files from antlr v2 to antlr v4:
    jboss-seam/src/main/antlr/org/jboss/seam/text/seam-text.g
    to (rename to g4)
    jboss-seam/src/main/antlr/org/jboss/seam/text/seam-text.g4
    change from v2 code style to v3 to v4.
  • Test

related items:
Migrating from ANTLR 3 to ANTLR 4
Migrating from ANTLR 2 to ANTLR 3
https://github.com/magsilva/antlr-v2-to-v3
processing/processing#3055

@albfernandez
Copy link
Owner

I've removed the maven plugin, now the source java file should be generated outside maven, and added to git tree.
This way we can test on IDE easily (important for testing after migrate to v4).

I've implemented some basic tests copied from seam documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants