Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detekt version to Inputs #6

Open
VovaStelmashchuk opened this issue Aug 19, 2020 · 4 comments
Open

Add detekt version to Inputs #6

VovaStelmashchuk opened this issue Aug 19, 2020 · 4 comments

Comments

@VovaStelmashchuk
Copy link
Contributor

No description provided.

@alaegin
Copy link
Owner

alaegin commented Aug 19, 2020

Hello!
As I can see you have already implemented such stuff in your fork. Could you create PR with the implementation?

@VovaStelmashchuk
Copy link
Contributor Author

I try, but have some trouble. I will return to the issue in next week.
Can you implement with by yourself?

@alaegin
Copy link
Owner

alaegin commented Aug 20, 2020

I try, but have some trouble. I will return to the issue in next week.
Can you implement with by yourself?

Ok. will try

@alaegin
Copy link
Owner

alaegin commented Aug 24, 2020

@VovaStelmashchuk After some research I've realized that it's not possible in an easy way. Currently we need to define detekt version as we need to download detekt binaries when building Docker image. If we want to use dynamic version we need to download all binaries.

Although we have the second way to do what you want. We will have two branches with this implementation. Action will run provided image if we didn't set dynamic one or download dynamic version every launch if it is defined.

In my opinion, the easiest way is to keep repository version updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants