Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/108 build a way for non engineer to iterate on the whisper prompt #109

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Feature/108 build a way for non engineer to iterate on the whisper prompt #109

wants to merge 13 commits into from

Conversation

wayangalihpratama
Copy link
Collaborator

@wayangalihpratama wayangalihpratama commented Oct 10, 2024 •
edited
Loading

  • Remember to remove prompt env from akvo-config

@wayangalihpratama wayangalihpratama self-assigned this Oct 10, 2024
@wayangalihpratama wayangalihpratama marked this pull request as draft October 10, 2024 07:02
@wayangalihpratama wayangalihpratama linked an issue Oct 10, 2024 that may be closed by this pull request
[SPRNT-174] Build a way for non engineer users to rapidly iterate on the whisper prompt #108
Open
@wayangalihpratama wayangalihpratama marked this pull request as ready for review October 13, 2024 23:14
kjkoster
kjkoster requested changes Oct 16, 2024
View reviewed changes
assistant/db/connection.py Show resolved Hide resolved
assistant/run.prod.sh Show resolved Hide resolved
assistant/db/prompt_query.py Show resolved Hide resolved
assistant/seeder/generate_prompt_sqlite.py Outdated Show resolved Hide resolved
docker-compose-rag-doll-only.yml
@@ -3,15 +3,6 @@ services:
build: assistant
environment:
ASSISTANT_LANGUAGES: ${ASSISTANT_LANGUAGES}
SYSTEM_PROMPT_en: ${SYSTEM_PROMPT_en}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also make a pull request on akvo-config to clean up the now-unused prompt files there.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still pending.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have created a PR on akvo-config and request your review @kjkoster

readme.md Show resolved Hide resolved
assistant/assistant.py Show resolved Hide resolved
assistant/tests/test_generate_prompt_sqlite.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dedenbangkit dedenbangkit dedenbangkit approved these changes

@kjkoster kjkoster kjkoster approved these changes

Assignees

@wayangalihpratama wayangalihpratama

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SPRNT-174] Build a way for non engineer users to rapidly iterate on the whisper prompt
3 participants
@wayangalihpratama @dedenbangkit @kjkoster