Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(ui): stage phase icon + tooltip missing for some phases #2776

Open
krancour opened this issue Oct 18, 2024 · 3 comments
Open

bug(ui): stage phase icon + tooltip missing for some phases #2776

krancour opened this issue Oct 18, 2024 · 3 comments

Comments

@krancour
Copy link
Member

krancour commented Oct 18, 2024

In this particular case, the Stage was in the new (as of #2762) Failed phase, so the UI not being prepared for that wasn't surprising, but I believe I've seen this occur many times prior to #2762. (I have a hunch that no phase (""), which is possible for a brand new Stage, may be unaccounted for.)

Screenshot 2024-10-17 at 4 04 18 PM

@Marvin9
Copy link
Contributor

Marvin9 commented Oct 29, 2024

@krancour thats Stage health status icon. Ok this UI code was a year ago and I think there was not "phase" initially? Or maybe health and phase had some correlation?

Anyways this needs to be changed if thats the case.

@krancour
Copy link
Member Author

@Marvin9 you're right. I have my wires crossed here. That icon is for health, and not for phase, as you correctly point out.

Health can legitimately be nil, especially for a brand new Stage that has not had any Promotions yet (or hasn't had any successful Promotions yet).

I wonder if nil health is the source of this.

@Marvin9
Copy link
Contributor

Marvin9 commented Oct 30, 2024

Yes nil health is the issue. But I think we should show both.. stage health + stage phase right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants