Add commit sha in log when Nelson tries to merge a PR (3/3) #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o NEL-add-commit-sha-in-log
This was referenced May 7, 2024
amigaire
changed the title
pchasle
approved these changes
May 7, 2024
nmarniesse
approved these changes
May 7, 2024
Beninho
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It displays the commit hash passed to Github via the API when Nelson tries to merge a PR.
I hope it will ease debugging. edit: it did
It uses the commit hash of the last commit to be merged in master (it previously used the commit hash of master).
We don't know yet why it stopped working
1/3: #73
2/3: #72
3/3: #71