-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP feat: allow cert-manager annotations on ingress based on environment variables PT.2 #112
Open
cloud-j-luna
wants to merge
19
commits into
akash-network:main
Choose a base branch
from
quasarch:luna/tls-cert-manager
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-j-luna
force-pushed
the
luna/tls-cert-manager
branch
from
April 18, 2023 19:06
faabd57
to
17eb424
Compare
Previously closed issue #86 |
troian
reviewed
Apr 18, 2023
troian
requested changes
Apr 18, 2023
i'll summarize requests here so it would be easier to follow
// sslEnable is a string type
if sslEnable != "" && sslEnable == "1" { do // sslEnable is a bool type
if sslEnable { provider run would be a good place to start |
troian
changed the title
feat: allow cert-manager annotations on ingress based on environment variables PT.2
WIP feat: allow cert-manager annotations on ingress based on environment variables PT.2
Apr 20, 2023
i marked it as WIP until all issues are resolved. feel free to remove when done |
cloud-j-luna
changed the title
WIP feat: allow cert-manager annotations on ingress based on environment variables PT.2
feat: allow cert-manager annotations on ingress based on environment variables PT.2
Apr 21, 2023
cloud-j-luna
changed the title
feat: allow cert-manager annotations on ingress based on environment variables PT.2
WIP feat: allow cert-manager annotations on ingress based on environment variables PT.2
Apr 23, 2023
…into luna/tls-cert-manager
andy108369
reviewed
Sep 6, 2024
@@ -21,7 +21,7 @@ kind-install-helm-chart-loki: | |||
helm upgrade --install promtail grafana/promtail \ | |||
--version $(PROMTAIL_VERSION) \ | |||
--namespace loki-stack \ | |||
-f ../promtail-values.yaml | |||
-f ../promtail-values.yamlk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it be yamlk
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows cert-manager annotations on ingress based on environment variables.