New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ObjectGraph refactor: Explicitly test for sealed-cyclic problem #212

Open

ajvincent opened this issue Aug 19, 2019 · 0 comments

Milestone

Owner

ajvincent commented Aug 19, 2019

Any sealed cycles should be solvable in the refactor by:

Creating each cycle's proxy object inside the membrane
Calling the ObjectGraph's head proxy handler directly with the new shadow target, NOT going through the new proxy.

This way, we don't trigger JS engine invariants until after the cycle is sealed.

Blocks #179

ajvincent added this to the refactor-0.10 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment