Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: wrap multipart scan response in json array brackets, include faulty status for missing filename #48

Open
arizon-dread opened this issue May 24, 2024 · 0 comments · May be fixed by #50

Comments

@arizon-dread
Copy link

arizon-dread commented May 24, 2024

I have a suggestion on the response json from the multipart scanning endpoint, but it's a breaking change. Since it contains one response for each file in the request, it should be wrapped in brackets to form a json array instead of multiple json documents.

My second proposition is that the if statement containing the continue action for when the multipart header filename is missing, should create an entry in the response with either a parse error or a plain error stating that the filename is missing.

Please close this issue if you find my suggestions irrelevant and supply why they are not feasible for implementation. If you find these suggestions valid, I volunteer to fork the project and implement them and then create a PR.

@arizon-dread arizon-dread linked a pull request Jun 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant