From cb6bf8bc08d3c2480f9e1d617e150b3f731dd5a4 Mon Sep 17 00:00:00 2001 From: Augustin Date: Tue, 27 Aug 2024 10:50:57 +0200 Subject: [PATCH] live-test: disable SortQueryParams addon (#44806) --- airbyte-ci/connectors/live-tests/README.md | 4 ++++ airbyte-ci/connectors/live-tests/pyproject.toml | 2 +- .../live-tests/src/live_tests/commons/mitm_addons.py | 7 ++++++- 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/airbyte-ci/connectors/live-tests/README.md b/airbyte-ci/connectors/live-tests/README.md index 4fb0d235ea38..e0bbc13b754b 100644 --- a/airbyte-ci/connectors/live-tests/README.md +++ b/airbyte-ci/connectors/live-tests/README.md @@ -279,6 +279,10 @@ The traffic recorded on the control connector is passed to the target connector ## Changelog +### 0.18.6 + +Disable the `SortQueryParams` MITM proxy addon to avoid double URL encoding. + ### 0.18.5 Relax test_oneof_usage criteria for constant value definitions in connector SPEC output. diff --git a/airbyte-ci/connectors/live-tests/pyproject.toml b/airbyte-ci/connectors/live-tests/pyproject.toml index 226f24ad7bed..daadc82a5e04 100644 --- a/airbyte-ci/connectors/live-tests/pyproject.toml +++ b/airbyte-ci/connectors/live-tests/pyproject.toml @@ -4,7 +4,7 @@ build-backend = "poetry.core.masonry.api" [tool.poetry] name = "live-tests" -version = "0.18.5" +version = "0.18.6" description = "Contains utilities for testing connectors against live data." authors = ["Airbyte "] license = "MIT" diff --git a/airbyte-ci/connectors/live-tests/src/live_tests/commons/mitm_addons.py b/airbyte-ci/connectors/live-tests/src/live_tests/commons/mitm_addons.py index 5bcfce2dafd5..032a80ebee23 100644 --- a/airbyte-ci/connectors/live-tests/src/live_tests/commons/mitm_addons.py +++ b/airbyte-ci/connectors/live-tests/src/live_tests/commons/mitm_addons.py @@ -25,4 +25,9 @@ def request(self, flow: http.HTTPFlow) -> None: flow.request.url = sorted_url -addons = [SortQueryParams()] +# Disabling the addon. +# It can alter the request URL when some connector URL are already encoded. +# See discussion here https://github.com/airbytehq/airbyte-internal-issues/issues/9302#issuecomment-2311854334 + +# addons = [SortQueryParams()] +addons = []