-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add support for rendering records as LLM documents #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 25, 2024
aaronsteers
changed the title
[Draft] Feat: Add support for rendering as documents
Feat: Add support for rendering as documents
Feb 27, 2024
aaronsteers
changed the title
Feat: Add support for rendering as documents
Feat: Add support for rendering records as LLM documents
Feb 27, 2024
efriis
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to:
Here we add a new
Document
class which is modeled after the LangChainDocument
class and should be compatible with similar LLM paradigms. The paradigm here is thatcontent
(orpage_content
) is a stringification of the record as a document, andmetadata
is a collection of all supporting fields that do not make up the primary content.Later, we can add top-level
id
andlast_updated
fields, which will help us later with deduplication.The new interfaces are:
Source.get_documents(stream_name, ...)
- this is sibling to the existing methodSource.get_records(stream_name, ...)
. Instead of returning an iterable of record dictionaries, we return an iterable of document objects.Dataset.to_documents(...)
- this is sibling to the existing methods:Dataset.to_sql_table()
andDataset.to_pandas()
.For comparison, please see the Langchain
Documents
class.Note: