Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Telemetry - Added "install" event type to track failed installs #115

Merged
merged 5 commits into from
Mar 13, 2024
Merged

Feat: Telemetry - Added "install" event type to track failed installs #115

merged 5 commits into from
Mar 13, 2024

Conversation

bindipankhudi
Copy link
Contributor

@bindipankhudi bindipankhudi commented Mar 9, 2024 •
edited
Loading

Related to #105

  • Added a new install type event (Currently info send for failed installs is same as what is send for failed syncs)
  • Confirmed that segment is receiving these events (sample install event below)
  • Confirmed that new install table is created in bigquery automatically. (screenshot below)
  • All tests are passing.
Screenshot 2024-03-10 at 7 48 31 PM Screenshot 2024-03-10 at 6 19 47 PM

@bindipankhudi bindipankhudi changed the title initial changes Feat: Telemetry - Added "install" event type to track failed installs Mar 11, 2024
@aaronsteers
Copy link
Contributor

Noyce! 🙌

aaronsteers
aaronsteers requested changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@aaronsteers aaronsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome. Nice work! One requested change, inline.

tests/unit_tests/test_anonymous_usage_stats.py Show resolved Hide resolved
@aaronsteers aaronsteers linked an issue Mar 12, 2024 that may be closed by this pull request
Add anonymized reporting of failed installs #105
Closed
aaronsteers
aaronsteers approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@aaronsteers aaronsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One suggestion inline. Otherwise, I think this is ready to go. 🚀

@bindipankhudi @aaronsteers
Update airbyte/sources/util.py
74e5035 
Co-authored-by: Aaron ("AJ") Steers <[email protected]>
@bindipankhudi bindipankhudi force-pushed the bindi/add-install-event-to-telemetry branch from 25a2310 to 74e5035 Compare March 13, 2024 02:02
@bindipankhudi bindipankhudi merged commit 3b26f81 into main Mar 13, 2024
11 checks passed
@bindipankhudi bindipankhudi deleted the bindi/add-install-event-to-telemetry branch March 13, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronsteers aaronsteers aaronsteers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add anonymized reporting of failed installs
2 participants
@bindipankhudi @aaronsteers