Add 'use_previous_backends' option. #106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This option defaults to true: if there are no default servers and a watcher reports no backends, then use the previous backends that we already know about. * Factor out code that updates '@backends' into the watcher base class.
|
this is great; i've been wanting to do a refactor like this for awhile. @jnb we talked about you becoming a maintainer of this repo. are you still interested? i have a few days this week to focus squarely on synapse, so i'm going to work on clearing out the current backlog and adding more unit testing. i've already done this for airbnb/nerve last week. |
|
Note, if you accept #115, that supersedes this change. |
|
cool, we'll just work with #115 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reports no backends, then use the previous backends that we already know
about.
@backendsinto the watcher base class.This code is running in production with no issues.