Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No support for relative server_port overrides #234

Open
udangel-r7 opened this issue Apr 27, 2017 · 1 comment
Open

No support for relative server_port overrides #234

udangel-r7 opened this issue Apr 27, 2017 · 1 comment

Comments

@udangel-r7
Copy link

haproxy supports relative port addresses, prefixed by a "+" or "-".

If this is set the server port is determined by adding the value to the client's port. In the base service_watcher there is currently a check to verify that the override port is an integer which breaks existing configurations.

I assume nginx doesn't support a similar behaviour, would you accept a patch or should we just maintain our own version?

@jolynch
Copy link
Collaborator

jolynch commented Aug 10, 2017

@udangel-r7

Since backend_port_override is provided by the user I've got no problem loosening the regex in the base watcher. If you all have a fork with a patch PR it and I can merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants