Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec2tag watcher needs to back off if Client.RequestLimitExceeded is returned #198

Open
ianbamforth opened this issue Jun 9, 2016 · 1 comment

Comments

@ianbamforth
Copy link

If you have a reasonable number of ec2tag watchers running, you can hit the rate limiter. Rather than a fixed check_interval, there should be a way of doing some kind of backoff (as per the AWS docs). If the Client.RequestLimitExceeded is returned, then there definitely needs to be a backoff - otherwise you just continue to hammer on the door, and the rate limit exceedance will never go away.

I'm yet to discover what the rate limit is, but I hit it today with ~6 servers each watching ~24 ec2tags (plus various other odds and sods running in the background) and the default check_interval

@ianbamforth
Copy link
Author

ianbamforth commented Jun 13, 2016

Even better would be to somehow combine the requests made to EC2 in the background - if you have 100 watchers that all need to get the Tags every 15 seconds, that can be achieved with a single request - rather than 100 requests each with a filter applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant