Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker watcher proposal: identify services by label instead of port and image name #121

Open
dnephin opened this issue May 16, 2015 · 0 comments

Comments

@dnephin
Copy link

dnephin commented May 16, 2015

Docker 1.6 added labels for images and containers.

Instead of requiring the same port for every service and exposing the port to the host (#109, #88), read a com.airbnb.synapse.service-port label from the image or container, and register the service using that port.

Another option might be to keep specifying the port in the watcher config, but look for a com.airbnb.synapse.service label.

Containers without a label would not be registered.

somic pushed a commit to somic/synapse that referenced this issue Mar 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant