Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce PEP 440 compliant versioning #1177

Closed
jakob-keller opened this issue Aug 23, 2024 · 0 comments · Fixed by #1178
Closed

Enforce PEP 440 compliant versioning #1177

jakob-keller opened this issue Aug 23, 2024 · 0 comments · Fixed by #1178
Assignees
@jakob-keller
Labels
needs-testcase

Comments

@jakob-keller
Copy link
Collaborator 

          > > 2.13.3-alpha

That's not compliant with PEP 440. It would be 2.13.3.a0 in Python ecosystem.

@jakob-keller we should have a test to ensure the CI fails if the version is invalid (can parse with disttools or something similar). Can do this next to our existing version checks

Originally posted by @thehesiod in #1163 (comment)
@jakob-keller jakob-keller mentioned this issue Aug 23, 2024
Merged
13 tasks
@jakob-keller jakob-keller self-assigned this Aug 23, 2024
jakob-keller added a commit to jakob-keller/aiobotocore that referenced this issue Aug 23, 2024
@jakob-keller
ensure aiobotocore.__version__ is in canonical form (aio-libs#1177)
770bc3b
@jakob-keller jakob-keller mentioned this issue Aug 23, 2024
Merged
13 tasks
jakob-keller added a commit that referenced this issue Aug 23, 2024
@jakob-keller
Merge pull request #1178 from jakob-keller/test-pep440
3e33588 
Ensure `aiobotocore.__version__` is in canonical form (#1177)
chemelli74 pushed a commit to chemelli74/aiobotocore that referenced this issue Aug 29, 2024
@jakob-keller @chemelli74
ensure aiobotocore.__version__ is in canonical form (aio-libs#1177)
896d1d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakob-keller jakob-keller

Labels
needs-testcase
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure aiobotocore.__version__ is in canonical form (#1177) jakob-keller/aiobotocore
1 participant
@jakob-keller