Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue1147 Use pathlib #228

Merged
merged 4 commits into from
Jul 26, 2024
Merged

Issue1147 Use pathlib #228

merged 4 commits into from
Jul 26, 2024

Conversation

FlorianPommerening
Copy link
Member

No description provided.

@FlorianPommerening FlorianPommerening changed the title Use pathlib Issue1147 Use pathlib Jul 23, 2024
FlorianPommerening
FlorianPommerening commented Jul 23, 2024
View reviewed changes
src/translate/pddl_parser/parsing_functions.py
@@ -297,7 +297,7 @@ def parse_literal(context, alist, type_dict, predicate_dict, negated=False):

if arity != len(alist) - 1:
context.error(f"Predicate '{predicate_name}' of arity {arity} used"
f" with {len(alist) -1} arguments.", alist)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to the issue but this was causing a failing style check locally.

@speckdavid speckdavid mentioned this pull request Jul 24, 2024
Draft
@speckdavid
Copy link

I checked the new logic for storing arguments for validation in args.validate_inputs. It looks good to me. The only somewhat strange behavior I noticed is that one can call translate and validate without search (e.g., ./fast-downward.py --translate --validate problem.pddl). This validates an old plan file sas_plan (possibly from another planning task) if it exists, or none if it doesn't. This behavior existed before in the main branch and isn't directly related to the pull request. Just asking if we want this behavior or if we should fix it.

@FlorianPommerening
Copy link
Member Author

The only somewhat strange behavior I noticed is that one can call translate and validate without search [...] This behavior existed before in the main branch and isn't directly related to the pull request.

We discussed this offline and decided to move this to a separate issue.

@FlorianPommerening FlorianPommerening merged commit bff55bb into aibasel:main Jul 26, 2024
11 checks passed
@FlorianPommerening FlorianPommerening deleted the issue1147 branch July 26, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltehelmert maltehelmert maltehelmert left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FlorianPommerening @speckdavid @maltehelmert