Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use modern CMake #164

Merged
merged 79 commits into from
Sep 15, 2023
Merged

Use modern CMake #164

merged 79 commits into from
Sep 15, 2023

Conversation

FlorianPommerening
Copy link
Member

I'm opening this to track changes, this is not ready yet.

silvansievers
silvansievers reviewed Aug 16, 2023
View reviewed changes
src/CMakeLists.txt Outdated Show resolved Hide resolved
FlorianPommerening
FlorianPommerening commented Sep 5, 2023
View reviewed changes
misc/tests/conftest.py Show resolved Hide resolved
misc/tests/conftest.py Outdated Show resolved Hide resolved
misc/tests/conftest.py Outdated Show resolved Hide resolved
misc/tests/conftest.py Outdated Show resolved Hide resolved
src/cmake_modules/FastDownwardMacros.cmake Outdated Show resolved Hide resolved
src/CMakeLists.txt Outdated Show resolved Hide resolved
FlorianPommerening
FlorianPommerening commented Sep 5, 2023
View reviewed changes
Copy link
Member Author

@FlorianPommerening FlorianPommerening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through some older commits and left some comments.

misc/tests/test-dependencies.py Outdated Show resolved Hide resolved
misc/tests/test-dependencies.py Outdated Show resolved Hide resolved
src/cmake_modules/FastDownwardMacros.cmake Outdated Show resolved Hide resolved
@FlorianPommerening
Use modern CMake
ae43bec
@remochristen @FlorianPommerening
Update Apple compiler ID string.
04c92e1
@remochristen @FlorianPommerening
Allow non-Apple clang again.
0ecab3e
@FlorianPommerening
Remove profile build, simplify build.py
aa2b316
@FlorianPommerening
Fix counting of CPUs
2b69623
@FlorianPommerening
Fix CMake generators
dadb7f1
@FlorianPommerening
More modern way of setting compiler requirements
5534719
@FlorianPommerening
Use versions in Cplex find script
edc8796
@salome-eriksson @FlorianPommerening
Replace 'set(CMAKE_*' calls.
4f149c4
@salome-eriksson @FlorianPommerening
AdBugfix: add PRIVATE keyword to target_link_libraries call
7cbd214
@FlorianPommerening
define plugins as interface libraries
e1e098a
@FlorianPommerening
add debug output
90bace8
@FlorianPommerening
restructure warnings and compiler-dependent code
f16bd72
@salome-eriksson @FlorianPommerening
Add debug output.
251af36
@salome-eriksson @FlorianPommerening
Remove debug output, specify COMPILER_ID var differently.
71c28fd
@salome-eriksson @FlorianPommerening
Yet another way to specify COMPILER_ID (needed if cmake version less …
e3af72a 
…than 3.1)
@salome-eriksson @FlorianPommerening
Fix typo.
c99c979
@FlorianPommerening
use generator expressions again
e4ccc42
@salome-eriksson @FlorianPommerening
Remove some TODOs, revert how to set output dir, revert commenting ou…
1a7041f 
…t code.
@salome-eriksson @FlorianPommerening
Trying out dirty hack for fixing windows cplex builds.
b838b68
@salome-eriksson @FlorianPommerening
Rename plugin to library.
3c1a5dc
@salome-eriksson @FlorianPommerening
Fix some code that still referenced plugin instead of library.
1de2904
@salome-eriksson @FlorianPommerening
Rename interface and warning library and build it as soon as FastDown…
8a8a3b0 
…wardMacros is included.
@FlorianPommerening
update documentation
0192d7c
remochristen and others added 28 commits September 12, 2023 15:11
@remochristen
Fix cmake copy command and comment out artifact deletion.
bb56ab7
@remochristen
Use uppercase library name, remove redundant DownwardFiles.cmake, and…
b5d6129 
… revert ubuntu workflow.
@remochristen
Move includes from macros to CMakeLists.
7330af3
@remochristen
Fix dependency test.
35c915c
@remochristen
Fix typos and add include guard.
2a7408b
@remochristen
Reformat dependencies.
cd132b7
@remochristen
Remove downward_ prefix from Fast Downward interface library names.
c40b386
@remochristen
Remove commented-out code.
bf407c6
@remochristen
Add debug functions.
92dc5df
@remochristen
Debug print cplex::cplex.
ba3a805
@remochristen
Print location variable.
8651926
@remochristen
New and improved debug printing.
accf431
@remochristen
Copy DLL in a stupid way.
b6bf7f8
@remochristen
Add debug prints to windows workflow.
93daeb5
@remochristen
Add CMake echos.
e371a7e
@remochristen
Fix CPLEX find script.
38b722d
@FlorianPommerening
check if CPLEX is a target after adding it
6504d79
@FlorianPommerening
add more debug output
403b5e5
@FlorianPommerening
add more debug output
9a7defd
@FlorianPommerening
try with generator expressions
bc0afd0
@FlorianPommerening
try with more generator expressions
40fb8d4
@FlorianPommerening
remove debug code
0b007a7
@FlorianPommerening
fix copy command for cases on windows without cplex
9ad0103
@FlorianPommerening
evaluate the option USE_GLIBCXX_DEBUG
87a61c5
@remochristen
Minor cleanups.
a9697e3
@FlorianPommerening
rename some variables in test
9d7bf2f
@remochristen
(C)Make last remaining single-line DEPENDS into multi-line.
c08f6be
@FlorianPommerening
simplify and document --suppress option in memory leak tests
69f2e32
@remochristen remochristen merged commit 6b192cd into aibasel:main Sep 15, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvansievers silvansievers silvansievers left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FlorianPommerening @silvansievers @remochristen @salome-eriksson